Added Async Disposable Action #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejsmith
reviewed
Oct 2, 2024
|
|
||
| _exitAction(); | ||
| _disposed = true; | ||
| var exitAction = Interlocked.Exchange(ref _exitAction, null); |
There was a problem hiding this comment.
Why add the locking here? I've never seen any dispose methods have locking in them. I'm pretty sure the .NET runtime isn't going to call dispose a bunch of times. I suppose you could call it manually a bunch of times in a row, but it still seems like overhead to add locking here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only usage across our libs is in test base which kinda made me want to remove DisposibleAction.
The other usages are for repositories and hence this add. I don't love the name.